Commit ad506586 authored by Chen Ni's avatar Chen Ni Committed by Jakub Kicinski
Browse files

dpll: fix return value check for kmemdup 



The return value of kmemdup() is dst->freq_supported, not
src->freq_supported. Update the check accordingly.

Fixes: 830ead5f ("dpll: fix pin dump crash for rebound module")
Signed-off-by: default avatarChen Ni <nichen@iscas.ac.cn>
Reviewed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: default avatarArkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20240513032824.2410459-1-nichen@iscas.ac.cn


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent f440092b

drivers/dpll/dpll_core.c

+1 −1
Original line number Diff line number Diff line
@@ -449,7 +449,7 @@ static int dpll_pin_prop_dup(const struct dpll_pin_properties *src, 
				   sizeof(*src->freq_supported);

		dst->freq_supported = kmemdup(src->freq_supported,

					      freq_size, GFP_KERNEL);

		if (!src->freq_supported)

		if (!dst->freq_supported)

			return -ENOMEM;

	}

	if (src->board_label) {