Commit ad511260 authored by Bjorn Andersson's avatar Bjorn Andersson Committed by Bjorn Andersson
Browse files

soc: qcom: pmic_glink: Actually communicate when remote goes down 



When the pmic_glink state is UP and we either receive a protection-
domain (PD) notification indicating that the PD is going down, or that
the whole remoteproc is going down, it's expected that the pmic_glink
client instances are notified that their function has gone DOWN.

This is not what the code does, which results in the client state either
not updating, or being wrong in many cases. So let's fix the conditions.

Fixes: 58ef4ece ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Tested-by: default avatarAmit Pundir <amit.pundir@linaro.org>
Reviewed-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Tested-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Signed-off-by: default avatarBjorn Andersson <quic_bjorande@quicinc.com>
Link: https://lore.kernel.org/r/20240820-pmic-glink-v6-11-races-v3-3-eec53c750a04@quicinc.com


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 11bb2ffb

drivers/soc/qcom/pmic_glink.c

+1 −1
Original line number Diff line number Diff line
@@ -191,7 +191,7 @@ static void pmic_glink_state_notify_clients(struct pmic_glink *pg) 
		if (pg->pdr_state == SERVREG_SERVICE_STATE_UP && pg->ept)

			new_state = SERVREG_SERVICE_STATE_UP;

	} else {

		if (pg->pdr_state == SERVREG_SERVICE_STATE_UP && pg->ept)

		if (pg->pdr_state == SERVREG_SERVICE_STATE_DOWN || !pg->ept)

			new_state = SERVREG_SERVICE_STATE_DOWN;

	}