Commit ad5f82ab authored by Thorsten Blum's avatar Thorsten Blum Committed by Takashi Iwai
Browse files

ALSA: pcmtest: Replace deprecated strcpy with strscpy_pad in setup_patt_bufs 

strcpy() has been deprecated [1] because it performs no bounds checking
on the destination buffer, which can lead to buffer overflows. Replace
it with the safer strscpy_pad(), and use kmalloc() instead of kzalloc()
because strscpy_pad() zero-pads the destination buffer and therefore
avoids writing to it twice.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy

 [1]
Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20251119135217.233084-1-thorsten.blum@linux.dev


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 18a48953

sound/drivers/pcmtest.c

+2 −2
Original line number Diff line number Diff line
@@ -696,10 +696,10 @@ static int setup_patt_bufs(void) 
	size_t i;



	for (i = 0; i < ARRAY_SIZE(patt_bufs); i++) {

		patt_bufs[i].buf = kzalloc(MAX_PATTERN_LEN, GFP_KERNEL);

		patt_bufs[i].buf = kmalloc(MAX_PATTERN_LEN, GFP_KERNEL);

		if (!patt_bufs[i].buf)

			break;

		strcpy(patt_bufs[i].buf, DEFAULT_PATTERN);

		strscpy_pad(patt_bufs[i].buf, DEFAULT_PATTERN, MAX_PATTERN_LEN);

		patt_bufs[i].len = DEFAULT_PATTERN_LEN;

	}