Commit add7000b authored by Yuan Can's avatar Yuan Can Committed by Vinod Koul
Browse files

phy: qcom-qmp-usb: Use dev_err_probe() to simplify code 



In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs.

Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarAndrew Halaney <ahalaney@redhat.com>
Link: https://lore.kernel.org/r/20220924070300.25080-5-yuancan@huawei.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 6d9b32fb

drivers/phy/qualcomm/phy-qcom-qmp-usb.c

+3 −6
Original line number Diff line number Diff line
@@ -2753,12 +2753,9 @@ static int qmp_usb_probe(struct platform_device *pdev) 
		return ret;



	ret = qmp_usb_vreg_init(dev, cfg);

	if (ret) {

		if (ret != -EPROBE_DEFER)

			dev_err(dev, "failed to get regulator supplies: %d\n",

				ret);

		return ret;

	}

	if (ret)

		return dev_err_probe(dev, ret,

				     "failed to get regulator supplies\n");



	num = of_get_available_child_count(dev->of_node);

	/* do we have a rogue child node ? */