Commit adecf78d authored by Inochi Amaoto's avatar Inochi Amaoto Committed by Thomas Gleixner
Browse files

irqchip/sifive-plic: Respect mask state when setting affinity 



plic_set_affinity() always calls plic_irq_enable(), which clears up the
priority setting even the interrupt is only masked. This unmasks the
interrupt unexpectly.

Replace the plic_irq_enable/disable() with plic_irq_toggle() to avoid
changing the priority setting.

Suggested-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarInochi Amaoto <inochiama@gmail.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Tested-by: Nam Cao <namcao@linutronix.de> # VisionFive 2
Tested-by: Chen Wang <unicorn_wang@outlook.com> # Pioneerbox
Reviewed-by: default avatarNam Cao <namcao@linutronix.de>
Reviewed-by: default avatarChen Wang <unicorn_wang@outlook.com>
Link: https://lore.kernel.org/all/20250811002633.55275-1-inochiama@gmail.com
Link: https://lore.kernel.org/lkml/20250722224513.22125-1-inochiama@gmail.com/
parent b92ff23b

drivers/irqchip/irq-sifive-plic.c

+4 −2
Original line number Diff line number Diff line
@@ -179,12 +179,14 @@ static int plic_set_affinity(struct irq_data *d, 
	if (cpu >= nr_cpu_ids)

		return -EINVAL;



	plic_irq_disable(d);

	/* Invalidate the original routing entry */

	plic_irq_toggle(irq_data_get_effective_affinity_mask(d), d, 0);



	irq_data_update_effective_affinity(d, cpumask_of(cpu));



	/* Setting the new routing entry if irq is enabled */

	if (!irqd_irq_disabled(d))

		plic_irq_enable(d);

		plic_irq_toggle(irq_data_get_effective_affinity_mask(d), d, 1);



	return IRQ_SET_MASK_OK_DONE;

}