Commit ae1d60c4 authored Jul 31, 2023 by Ruan Jinjie Committed by Jakub Kicinski Aug 02, 2023

net: hisilicon: fix the return value handle and remove redundant netdev_err()...

net: hisilicon: fix the return value handle and remove redundant netdev_err() for platform_get_irq()

There is no possible for platform_get_irq() to return 0
and the return value of platform_get_irq() is more sensible
to show the error reason.

And there is no need to call the netdev_err() function directly to print
a custom message when handling an error from platform_get_irq() function as
it is going to display an appropriate error message in case of a failure.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20230731073858.3633193-1-ruanjinjie@huawei.com

Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 34093c9f

drivers/net/ethernet/hisilicon/hip04_eth.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -960,8 +960,8 @@ static int hip04_mac_probe(struct platform_device *pdev)
		}

		irq = platform_get_irq(pdev, 0);
		if (irq <= 0) {
		ret = -EINVAL;
		if (irq < 0) {
		ret = irq;
		goto init_fail;
		}

drivers/net/ethernet/hisilicon/hisi_femac.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -862,8 +862,8 @@ static int hisi_femac_drv_probe(struct platform_device *pdev)
		goto out_disconnect_phy;

		ndev->irq = platform_get_irq(pdev, 0);
		if (ndev->irq <= 0) {
		ret = -ENODEV;
		if (ndev->irq < 0) {
		ret = ndev->irq;
		goto out_disconnect_phy;
		}

drivers/net/ethernet/hisilicon/hix5hd2_gmac.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -1206,9 +1206,8 @@ static int hix5hd2_dev_probe(struct platform_device *pdev)
		}

		ndev->irq = platform_get_irq(pdev, 0);
		if (ndev->irq <= 0) {
		netdev_err(ndev, "No irq resource\n");
		ret = -EINVAL;
		if (ndev->irq < 0) {
		ret = ndev->irq;
		goto out_phy_node;
		}