Commit ae2fafc1 authored by Zhenzhong Duan's avatar Zhenzhong Duan Committed by Joerg Roedel
Browse files

iommu/vt-d: Support dirty tracking on PASID 



In order to support passthrough device with PASID capability in QEMU,
e.g., DSA device, kernel needs to support attaching PASID to a domain.

But attaching is not allowed if the domain is a second stage domain or
nested domain with dirty tracking.

The reason is kernel lacking support for dirty tracking on such domain
attached to PASID. By adding dirty tracking on PASID, the check can be
removed.

Signed-off-by: default avatarZhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: default avatarYi Liu <yi.l.liu@intel.com>
Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
Link: https://lore.kernel.org/r/20260330101108.12594-4-zhenzhong.duan@intel.com


Signed-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: default avatarJoerg Roedel <joerg.roedel@amd.com>
parent 922e2598

drivers/iommu/intel/iommu.c

+9 −3
Original line number Diff line number Diff line
@@ -3618,9 +3618,6 @@ static int intel_iommu_set_dev_pasid(struct iommu_domain *domain, 
	if (!pasid_supported(iommu) || dev_is_real_dma_subdevice(dev))

		return -EOPNOTSUPP;



	if (domain->dirty_ops)

		return -EINVAL;



	if (context_copied(iommu, info->bus, info->devfn))

		return -EBUSY;
@@ -3688,6 +3685,7 @@ static void *intel_iommu_hw_info(struct device *dev, u32 *length, 
static int domain_set_dirty_tracking(struct dmar_domain *domain, bool enable)

{

	struct device_domain_info *info;

	struct dev_pasid_info *dev_pasid;

	int ret = 0;



	lockdep_assert_held(&domain->lock);
@@ -3695,6 +3693,14 @@ static int domain_set_dirty_tracking(struct dmar_domain *domain, bool enable) 
	list_for_each_entry(info, &domain->devices, link) {

		ret = intel_pasid_setup_dirty_tracking(info->iommu, info->dev,

						       IOMMU_NO_PASID, enable);

		if (ret)

			return ret;

	}



	list_for_each_entry(dev_pasid, &domain->dev_pasids, link_domain) {

		info = dev_iommu_priv_get(dev_pasid->dev);

		ret = intel_pasid_setup_dirty_tracking(info->iommu, info->dev,

						       dev_pasid->pasid, enable);

		if (ret)

			break;

	}

drivers/iommu/intel/nested.c

+1 −5
Original line number Diff line number Diff line
@@ -148,7 +148,6 @@ static int intel_nested_set_dev_pasid(struct iommu_domain *domain, 
{

	struct device_domain_info *info = dev_iommu_priv_get(dev);

	struct dmar_domain *dmar_domain = to_dmar_domain(domain);

	struct iommu_domain *s2_domain = &dmar_domain->s2_domain->domain;

	struct intel_iommu *iommu = info->iommu;

	struct dev_pasid_info *dev_pasid;

	int ret;
@@ -156,13 +155,10 @@ static int intel_nested_set_dev_pasid(struct iommu_domain *domain, 
	if (!pasid_supported(iommu) || dev_is_real_dma_subdevice(dev))

		return -EOPNOTSUPP;



	if (s2_domain->dirty_ops)

		return -EINVAL;



	if (context_copied(iommu, info->bus, info->devfn))

		return -EBUSY;



	ret = paging_domain_compatible(s2_domain, dev);

	ret = paging_domain_compatible(&dmar_domain->s2_domain->domain, dev);

	if (ret)

		return ret;