Commit ae3683a3 authored by Kurt Kanzenbach's avatar Kurt Kanzenbach Committed by Jakub Kicinski
Browse files

net: dsa: hellcreek: Replace bogus comment 



Replace bogus comment about matching the latched timestamp to one of the
received frames. That comment is probably copied from mv88e6xxx and true for
these switches. However, the hellcreek switch is configured to insert the
timestamp directly into the PTP packets.

While here, remove the other comments regarding the list splicing and locking as
well, because it doesn't add any value.

Signed-off-by: default avatarKurt Kanzenbach <kurt@linutronix.de>
Reviewed-by: default avatarVladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20230801131647.84697-1-kurt@linutronix.de


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ae336f30

drivers/net/dsa/hirschmann/hellcreek_hwtstamp.c

+1 −8
Original line number Diff line number Diff line
@@ -298,17 +298,10 @@ static void hellcreek_get_rxts(struct hellcreek *hellcreek, 
	struct sk_buff_head received;

	unsigned long flags;



	/* The latched timestamp belongs to one of the received frames. */

	/* Construct Rx timestamps for all received PTP packets. */

	__skb_queue_head_init(&received);



	/* Lock & disable interrupts */

	spin_lock_irqsave(&rxq->lock, flags);



	/* Add the reception queue "rxq" to the "received" queue an reintialize

	 * "rxq".  From now on, we deal with "received" not with "rxq"

	 */

	skb_queue_splice_tail_init(rxq, &received);



	spin_unlock_irqrestore(&rxq->lock, flags);



	for (; skb; skb = __skb_dequeue(&received)) {