Commit ae4ac077 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jiri Kosina
Browse files

HID: intel-thc-hid: Intel-quickspi: Fix some error codes 



If we have a partial read that is supposed to be treated as failure but
in this code we forgot to set the error code.  Return -EINVAL.

Fixes: 9d8d5173 ("HID: intel-thc-hid: intel-quickspi: Add HIDSPI protocol implementation")
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Reviewed-by: default avatarEven Xu <even.xu@intel.com>
Reviewed-by: default avatarMark Pearson <mpearson-lenovo@squebb.ca>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 3524900c

drivers/hid/intel-thc-hid/intel-quickspi/quickspi-protocol.c

+2 −2
Original line number Diff line number Diff line
@@ -94,7 +94,7 @@ static int quickspi_get_device_descriptor(struct quickspi_device *qsdev) 
		dev_err_once(qsdev->dev, "Read DEVICE_DESCRIPTOR failed, ret = %d\n", ret);

		dev_err_once(qsdev->dev, "DEVICE_DESCRIPTOR expected len = %u, actual read = %u\n",

			     input_len, read_len);

		return ret;

		return ret ?: -EINVAL;

	}



	input_rep_type = ((struct input_report_body_header *)read_buf)->input_report_type;
@@ -318,7 +318,7 @@ int reset_tic(struct quickspi_device *qsdev) 
		dev_err_once(qsdev->dev, "Read RESET_RESPONSE body failed, ret = %d\n", ret);

		dev_err_once(qsdev->dev, "RESET_RESPONSE body expected len = %u, actual = %u\n",

			     read_len, actual_read_len);

		return ret;

		return ret ?: -EINVAL;

	}



	input_rep_type = FIELD_GET(HIDSPI_IN_REP_BDY_HDR_REP_TYPE, reset_response);