Commit ae5c6777 authored by Waiman Long's avatar Waiman Long Committed by Peter Zijlstra
Browse files

sched/core: Remove HK_TYPE_SCHED 



The HK_TYPE_SCHED housekeeping type is defined but not set anywhere. So
any code that try to use HK_TYPE_SCHED are essentially dead code. So
remove HK_TYPE_SCHED and any code that use it.

Signed-off-by: default avatarWaiman Long <longman@redhat.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: default avatarFrederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/r/20241030175253.125248-2-longman@redhat.com
parent a76328d4

include/linux/sched/isolation.h

+0 −1
Original line number Diff line number Diff line
@@ -10,7 +10,6 @@ enum hk_type { 
	HK_TYPE_TIMER,

	HK_TYPE_RCU,

	HK_TYPE_MISC,

	HK_TYPE_SCHED,

	HK_TYPE_TICK,

	HK_TYPE_DOMAIN,

	HK_TYPE_WQ,

kernel/sched/fair.c

+0 −14
Original line number Diff line number Diff line
@@ -12197,9 +12197,6 @@ static inline int on_null_domain(struct rq *rq) 
 * - When one of the busy CPUs notices that there may be an idle rebalancing

 *   needed, they will kick the idle load balancer, which then does idle

 *   load balancing for all the idle CPUs.

 *

 * - HK_TYPE_MISC CPUs are used for this task, because HK_TYPE_SCHED is not set

 *   anywhere yet.

 */

static inline int find_new_ilb(void)

{
@@ -12444,10 +12441,6 @@ void nohz_balance_enter_idle(int cpu) 
	if (!cpu_active(cpu))

		return;



	/* Spare idle load balancing on CPUs that don't want to be disturbed: */

	if (!housekeeping_cpu(cpu, HK_TYPE_SCHED))

		return;



	/*

	 * Can be set safely without rq->lock held

	 * If a clear happens, it will have evaluated last additions because
@@ -12667,13 +12660,6 @@ static void nohz_newidle_balance(struct rq *this_rq) 
{

	int this_cpu = this_rq->cpu;



	/*

	 * This CPU doesn't want to be disturbed by scheduler

	 * housekeeping

	 */

	if (!housekeeping_cpu(this_cpu, HK_TYPE_SCHED))

		return;



	/* Will wake up very soon. No time for doing anything else*/

	if (this_rq->avg_idle < sysctl_sched_migration_cost)

		return;

kernel/sched/isolation.c

+0 −1
Original line number Diff line number Diff line
@@ -12,7 +12,6 @@ enum hk_flags { 
	HK_FLAG_TIMER		= BIT(HK_TYPE_TIMER),

	HK_FLAG_RCU		= BIT(HK_TYPE_RCU),

	HK_FLAG_MISC		= BIT(HK_TYPE_MISC),

	HK_FLAG_SCHED		= BIT(HK_TYPE_SCHED),

	HK_FLAG_TICK		= BIT(HK_TYPE_TICK),

	HK_FLAG_DOMAIN		= BIT(HK_TYPE_DOMAIN),

	HK_FLAG_WQ		= BIT(HK_TYPE_WQ),