Commit ae8bcae8 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: xra1403: use new GPIO line value setter callbacks 

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Link: https://lore.kernel.org/r/20250709-gpiochip-set-rv-gpio-remaining-v1-13-b8950f69618d@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 6d0f71cd

drivers/gpio/gpio-xra1403.c

+5 −8
Original line number Diff line number Diff line
@@ -102,16 +102,13 @@ static int xra1403_get(struct gpio_chip *chip, unsigned int offset) 
	return !!(val & BIT(offset % 8));

}



static void xra1403_set(struct gpio_chip *chip, unsigned int offset, int value)

static int xra1403_set(struct gpio_chip *chip, unsigned int offset, int value)

{

	int ret;

	struct xra1403 *xra = gpiochip_get_data(chip);



	ret = regmap_update_bits(xra->regmap, to_reg(XRA_OCR, offset),

			BIT(offset % 8), value ? BIT(offset % 8) : 0);

	if (ret)

		dev_err(chip->parent, "Failed to set pin: %d, ret: %d\n",

				offset, ret);

	return regmap_update_bits(xra->regmap, to_reg(XRA_OCR, offset),

				  BIT(offset % 8),

				  value ? BIT(offset % 8) : 0);

}



#ifdef CONFIG_DEBUG_FS
@@ -167,7 +164,7 @@ static int xra1403_probe(struct spi_device *spi) 
	xra->chip.direction_output = xra1403_direction_output;

	xra->chip.get_direction = xra1403_get_direction;

	xra->chip.get = xra1403_get;

	xra->chip.set = xra1403_set;

	xra->chip.set_rv = xra1403_set;



	xra->chip.dbg_show = xra1403_dbg_show;