Commit aeb90c40 authored by Stefan Wahren's avatar Stefan Wahren Committed by Jakub Kicinski
Browse files

net: vertexcom: mse102x: Drop invalid cmd stats 



There are several reasons for an invalid command response
by the MSE102x:
* SPI line interferences
* MSE102x is in reset or has no firmware
* MSE102x is busy
* no packet in MSE102x receive buffer

So the counter for invalid command isn't very helpful without
further context. So drop the confusing statistics counter,
but keep the debug messages about "unexpected response" in order
to debug possible hardware issues.

Signed-off-by: default avatarStefan Wahren <wahrenst@gmx.net>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20250509120435.43646-4-wahrenst@gmx.net


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent fed56943

drivers/net/ethernet/vertexcom/mse102x.c

+0 −3
Original line number Diff line number Diff line
@@ -46,7 +46,6 @@ 


struct mse102x_stats {

	u64 xfer_err;

	u64 invalid_cmd;

	u64 invalid_ctr;

	u64 invalid_dft;

	u64 invalid_len;
@@ -57,7 +56,6 @@ struct mse102x_stats { 


static const char mse102x_gstrings_stats[][ETH_GSTRING_LEN] = {

	"SPI transfer errors",

	"Invalid command",

	"Invalid CTR",

	"Invalid DFT",

	"Invalid frame length",
@@ -195,7 +193,6 @@ static int mse102x_rx_cmd_spi(struct mse102x_net *mse, u8 *rxb) 
	} else if (*cmd != cpu_to_be16(DET_CMD)) {

		net_dbg_ratelimited("%s: Unexpected response (0x%04x)\n",

				    __func__, *cmd);

		mse->stats.invalid_cmd++;

		ret = -EIO;

	} else {

		memcpy(rxb, trx + 2, 2);