Commit aee0f01b authored by Nikola Z. Ivanov's avatar Nikola Z. Ivanov Committed by Jakub Kicinski
Browse files

team: Add matching error label for failed action 



Follow the "action" - "err_action" pairing of labels
found across the source code of team net device.

Currently in team_port_add the err_set_slave_promisc
label is reused for exiting on error when setting
allmulti level of the new slave.

Signed-off-by: default avatarNikola Z. Ivanov <zlatistiv@gmail.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Link: https://patch.msgid.link/20251128072544.223645-1-zlatistiv@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 9bf66036

drivers/net/team/team_core.c

+2 −1
Original line number Diff line number Diff line
@@ -1231,7 +1231,7 @@ static int team_port_add(struct team *team, struct net_device *port_dev, 
		if (err) {

			if (dev->flags & IFF_PROMISC)

				dev_set_promiscuity(port_dev, -1);

			goto err_set_slave_promisc;

			goto err_set_slave_allmulti;

		}

	}
@@ -1258,6 +1258,7 @@ static int team_port_add(struct team *team, struct net_device *port_dev, 
	return 0;



err_set_dev_type:

err_set_slave_allmulti:

err_set_slave_promisc:

	__team_option_inst_del_port(team, port);