Commit aee70a1d authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

USB: dwc3: qcom: simplify wakeup interrupt setup 



Use the IRQF_NO_AUTOEN irq flag when requesting the wakeup interrupts
instead of setting it separately.

No functional change intended.

Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarAndrew Halaney <ahalaney@redhat.com>
Link: https://lore.kernel.org/r/20231120161607.7405-4-johan+linaro@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 41f5a097

drivers/usb/dwc3/dwc3-qcom.c

+4 −8
Original line number Diff line number Diff line
@@ -546,10 +546,9 @@ static int dwc3_qcom_setup_irq(struct platform_device *pdev) 
				pdata ? pdata->hs_phy_irq_index : -1);

	if (irq > 0) {

		/* Keep wakeup interrupts disabled until suspend */

		irq_set_status_flags(irq, IRQ_NOAUTOEN);

		ret = devm_request_threaded_irq(qcom->dev, irq, NULL,

					qcom_dwc3_resume_irq,

					IRQF_ONESHOT,

					IRQF_ONESHOT | IRQF_NO_AUTOEN,

					"qcom_dwc3 HS", qcom);

		if (ret) {

			dev_err(qcom->dev, "hs_phy_irq failed: %d\n", ret);
@@ -561,10 +560,9 @@ static int dwc3_qcom_setup_irq(struct platform_device *pdev) 
	irq = dwc3_qcom_get_irq(pdev, "dp_hs_phy_irq",

				pdata ? pdata->dp_hs_phy_irq_index : -1);

	if (irq > 0) {

		irq_set_status_flags(irq, IRQ_NOAUTOEN);

		ret = devm_request_threaded_irq(qcom->dev, irq, NULL,

					qcom_dwc3_resume_irq,

					IRQF_ONESHOT,

					IRQF_ONESHOT | IRQF_NO_AUTOEN,

					"qcom_dwc3 DP_HS", qcom);

		if (ret) {

			dev_err(qcom->dev, "dp_hs_phy_irq failed: %d\n", ret);
@@ -576,10 +574,9 @@ static int dwc3_qcom_setup_irq(struct platform_device *pdev) 
	irq = dwc3_qcom_get_irq(pdev, "dm_hs_phy_irq",

				pdata ? pdata->dm_hs_phy_irq_index : -1);

	if (irq > 0) {

		irq_set_status_flags(irq, IRQ_NOAUTOEN);

		ret = devm_request_threaded_irq(qcom->dev, irq, NULL,

					qcom_dwc3_resume_irq,

					IRQF_ONESHOT,

					IRQF_ONESHOT | IRQF_NO_AUTOEN,

					"qcom_dwc3 DM_HS", qcom);

		if (ret) {

			dev_err(qcom->dev, "dm_hs_phy_irq failed: %d\n", ret);
@@ -591,10 +588,9 @@ static int dwc3_qcom_setup_irq(struct platform_device *pdev) 
	irq = dwc3_qcom_get_irq(pdev, "ss_phy_irq",

				pdata ? pdata->ss_phy_irq_index : -1);

	if (irq > 0) {

		irq_set_status_flags(irq, IRQ_NOAUTOEN);

		ret = devm_request_threaded_irq(qcom->dev, irq, NULL,

					qcom_dwc3_resume_irq,

					IRQF_ONESHOT,

					IRQF_ONESHOT | IRQF_NO_AUTOEN,

					"qcom_dwc3 SS", qcom);

		if (ret) {

			dev_err(qcom->dev, "ss_phy_irq failed: %d\n", ret);