Commit aeeb4c7f authored by Sean Christopherson's avatar Sean Christopherson
Browse files

KVM: x86: Drop semi-arbitrary restrictions on IPI type in fastpath 

Drop the restrictions on fastpath IPIs only working for fixed IRQs with a
physical destination now that the fastpath is explicitly limited to "fast"
delivery.  Limiting delivery to a single physical APIC ID guarantees only
one vCPU will receive the event, but that isn't necessary "fast", e.g. if
the targeted vCPU is the last of 4096 vCPUs.  And logical destination mode
or shorthand (to self) can also be fast, e.g. if only a few vCPUs are
being targeted.  Lastly, there's nothing inherently slow about delivering
an NMI, INIT, SIPI, SMI, etc., i.e. there's no reason to artificially
limit fastpath delivery to fixed vector IRQs.

Link: https://lore.kernel.org/r/20250805190526.1453366-5-seanjc@google.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent 77741434

arch/x86/kvm/x86.c

+1 −7
Original line number Diff line number Diff line
@@ -2146,13 +2146,7 @@ static int handle_fastpath_set_x2apic_icr_irqoff(struct kvm_vcpu *vcpu, u64 data 
	if (!lapic_in_kernel(vcpu) || !apic_x2apic_mode(vcpu->arch.apic))

		return 1;



	if (((data & APIC_SHORT_MASK) == APIC_DEST_NOSHORT) &&

	    ((data & APIC_DEST_MASK) == APIC_DEST_PHYSICAL) &&

	    ((data & APIC_MODE_MASK) == APIC_DM_FIXED) &&

	    ((u32)(data >> 32) != X2APIC_BROADCAST))

	return kvm_x2apic_icr_write_fast(vcpu->arch.apic, data);



	return 1;

}



static int handle_fastpath_set_tscdeadline(struct kvm_vcpu *vcpu, u64 data)