Commit aef855df authored by Dinghao Liu's avatar Dinghao Liu Committed by Saeed Mahameed
Browse files

net/mlx5e: fix a potential double-free in fs_any_create_groups 



When kcalloc() for ft->g succeeds but kvzalloc() for in fails,
fs_any_create_groups() will free ft->g. However, its caller
fs_any_create_table() will free ft->g again through calling
mlx5e_destroy_flow_table(), which will lead to a double-free.
Fix this by setting ft->g to NULL in fs_any_create_groups().

Fixes: 0f575c20 ("net/mlx5e: Introduce Flow Steering ANY API")
Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 3c6d5189

drivers/net/ethernet/mellanox/mlx5/core/en/fs_tt_redirect.c

+1 −0
Original line number Diff line number Diff line
@@ -436,6 +436,7 @@ static int fs_any_create_groups(struct mlx5e_flow_table *ft) 
	in = kvzalloc(inlen, GFP_KERNEL);

	if  (!in || !ft->g) {

		kfree(ft->g);

		ft->g = NULL;

		kvfree(in);

		return -ENOMEM;

	}