Commit af00d488 authored by Mateusz Majewski's avatar Mateusz Majewski Committed by Daniel Lezcano
Browse files

thermal/drivers/exynos: Use BIT wherever possible 



The original driver did not use that macro and it allows us to make our
intentions slightly clearer.

Reviewed-by: default avatarLukasz Luba <lukasz.luba@arm.com>
Signed-off-by: default avatarMateusz Majewski <m.majewski2@samsung.com>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20231201095625.301884-9-m.majewski2@samsung.com
parent b72ba67b

drivers/thermal/samsung/exynos_tmu.c

+12 −12
Original line number Diff line number Diff line
@@ -388,7 +388,7 @@ static void exynos4412_tmu_set_trip_temp(struct exynos_tmu_data *data, 


	if (trip == 3) {

		con = readl(data->base + EXYNOS_TMU_REG_CONTROL);

		con |= (1 << EXYNOS_TMU_THERM_TRIP_EN_SHIFT);

		con |= BIT(EXYNOS_TMU_THERM_TRIP_EN_SHIFT);

		writel(con, data->base + EXYNOS_TMU_REG_CONTROL);

	}

}
@@ -559,16 +559,16 @@ static void exynos4210_tmu_control(struct platform_device *pdev, bool on) 
				continue;



			interrupt_en |=

				(1 << (EXYNOS_TMU_INTEN_RISE0_SHIFT + i * 4));

				BIT(EXYNOS_TMU_INTEN_RISE0_SHIFT + i * 4);

		}



		if (data->soc != SOC_ARCH_EXYNOS4210)

			interrupt_en |=

				interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT;



		con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT);

		con |= BIT(EXYNOS_TMU_CORE_EN_SHIFT);

	} else {

		con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT);

		con &= ~BIT(EXYNOS_TMU_CORE_EN_SHIFT);

	}



	writel(interrupt_en, data->base + EXYNOS_TMU_REG_INTEN);
@@ -590,15 +590,15 @@ static void exynos5433_tmu_control(struct platform_device *pdev, bool on) 
				continue;



			interrupt_en |=

				(1 << (EXYNOS7_TMU_INTEN_RISE0_SHIFT + i));

				BIT(EXYNOS7_TMU_INTEN_RISE0_SHIFT + i);

		}



		interrupt_en |=

			interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT;



		con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT);

		con |= BIT(EXYNOS_TMU_CORE_EN_SHIFT);

	} else

		con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT);

		con &= ~BIT(EXYNOS_TMU_CORE_EN_SHIFT);



	pd_det_en = on ? EXYNOS5433_PD_DET_EN : 0;
@@ -622,17 +622,17 @@ static void exynos7_tmu_control(struct platform_device *pdev, bool on) 
				continue;



			interrupt_en |=

				(1 << (EXYNOS7_TMU_INTEN_RISE0_SHIFT + i));

				BIT(EXYNOS7_TMU_INTEN_RISE0_SHIFT + i);

		}



		interrupt_en |=

			interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT;



		con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT);

		con |= (1 << EXYNOS7_PD_DET_EN_SHIFT);

		con |= BIT(EXYNOS_TMU_CORE_EN_SHIFT);

		con |= BIT(EXYNOS7_PD_DET_EN_SHIFT);

	} else {

		con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT);

		con &= ~(1 << EXYNOS7_PD_DET_EN_SHIFT);

		con &= ~BIT(EXYNOS_TMU_CORE_EN_SHIFT);

		con &= ~BIT(EXYNOS7_PD_DET_EN_SHIFT);

	}



	writel(interrupt_en, data->base + EXYNOS7_TMU_REG_INTEN);