Commit af048ec9 authored by Dan Carpenter's avatar Dan Carpenter Committed by Will Deacon
Browse files

iommu/arm-smmu-v3: Fix a NULL vs IS_ERR() check 



The arm_smmu_domain_alloc() function returns error pointers on error.  It
doesn't return NULL.  Update the error checking to match.

Fixes: 52acd7d8 ("iommu/arm-smmu-v3: Add support for domain_alloc_user fn")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarShameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/9208cd0d-8105-40df-93e9-bdcdf0d55eec@stanley.mountain


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent df498819

drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c

+2 −2
Original line number Diff line number Diff line
@@ -3062,8 +3062,8 @@ arm_smmu_domain_alloc_user(struct device *dev, u32 flags, 
		return ERR_PTR(-EOPNOTSUPP);



	smmu_domain = arm_smmu_domain_alloc();

	if (!smmu_domain)

		return ERR_PTR(-ENOMEM);

	if (IS_ERR(smmu_domain))

		return ERR_CAST(smmu_domain);



	smmu_domain->domain.type = IOMMU_DOMAIN_UNMANAGED;

	smmu_domain->domain.ops = arm_smmu_ops.default_domain_ops;