Commit af1e0a7d authored by Dawei Li's avatar Dawei Li Committed by Conor Dooley
Browse files

firmware: microchip: Fix over-requested allocation size 



cocci warnings: (new ones prefixed by >>)
>> drivers/firmware/microchip/mpfs-auto-update.c:387:72-78:
   ERROR: application of sizeof to pointer
   drivers/firmware/microchip/mpfs-auto-update.c:170:72-78:
   ERROR: application of sizeof to pointer

response_msg is a pointer to u32, so the size of element it points to is
supposed to be a multiple of sizeof(u32), rather than sizeof(u32 *).

Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202403040516.CYxoWTXw-lkp@intel.com/


Signed-off-by: default avatarDawei Li <dawei.li@shingroup.cn>
Fixes: ec5b0f11 ("firmware: microchip: add PolarFire SoC Auto Update support")
Signed-off-by: default avatarConor Dooley <conor.dooley@microchip.com>
parent 6613476e

drivers/firmware/microchip/mpfs-auto-update.c

+2 −1
Original line number Diff line number Diff line
@@ -384,7 +384,8 @@ static int mpfs_auto_update_available(struct mpfs_auto_update_priv *priv) 
	u32 *response_msg;

	int ret;



	response_msg = devm_kzalloc(priv->dev, AUTO_UPDATE_FEATURE_RESP_SIZE * sizeof(response_msg),

	response_msg = devm_kzalloc(priv->dev,

				    AUTO_UPDATE_FEATURE_RESP_SIZE * sizeof(*response_msg),

				    GFP_KERNEL);

	if (!response_msg)

		return -ENOMEM;