Commit af3973e7 authored by Thomas Fourier's avatar Thomas Fourier Committed by Martin K. Petersen
Browse files

scsi: snic: Remove unused linkstatus 



The (struct vnic_dev).linkstatus buffer is freed in svnic_dev_unregister()
and referenced in svnic_dev_link_status() but never alloc'd. This means
(struct vnic_dev).linkstatus is always null and the dealloc the reference
in svnic_dev_link_status() is dead code.

Signed-off-by: default avatarThomas Fourier <fourier.thomas@gmail.com>
Acked-by: default avatarKaran Tilak Kumar <kartilak@cisco.com>
Link: https://patch.msgid.link/20260216141056.59429-2-fourier.thomas@gmail.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 38353c26

drivers/scsi/snic/vnic_dev.c

+0 −9
Original line number Diff line number Diff line
@@ -42,8 +42,6 @@ struct vnic_dev { 
	struct vnic_devcmd_notify *notify;

	struct vnic_devcmd_notify notify_copy;

	dma_addr_t notify_pa;

	u32 *linkstatus;

	dma_addr_t linkstatus_pa;

	struct vnic_stats *stats;

	dma_addr_t stats_pa;

	struct vnic_devcmd_fw_info *fw_info;
@@ -650,8 +648,6 @@ int svnic_dev_init(struct vnic_dev *vdev, int arg) 


int svnic_dev_link_status(struct vnic_dev *vdev)

{

	if (vdev->linkstatus)

		return *vdev->linkstatus;



	if (!vnic_dev_notify_ready(vdev))

		return 0;
@@ -686,11 +682,6 @@ void svnic_dev_unregister(struct vnic_dev *vdev) 
				sizeof(struct vnic_devcmd_notify),

				vdev->notify,

				vdev->notify_pa);

		if (vdev->linkstatus)

			dma_free_coherent(&vdev->pdev->dev,

				sizeof(u32),

				vdev->linkstatus,

				vdev->linkstatus_pa);

		if (vdev->stats)

			dma_free_coherent(&vdev->pdev->dev,

				sizeof(struct vnic_stats),