Commit af728722 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Lee Jones
Browse files

leds: pca9532: Simplify with scoped for each OF child loop 



Use scoped for_each_available_child_of_node_scoped() when iterating over
device nodes to make code a bit simpler.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240816-cleanup-h-of-node-put-var-v1-14-1d0292802470@linaro.org


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent d3f5f674

drivers/leds/leds-pca9532.c

+2 −5
Original line number Diff line number Diff line
@@ -506,7 +506,6 @@ static struct pca9532_platform_data * 
pca9532_of_populate_pdata(struct device *dev, struct device_node *np)

{

	struct pca9532_platform_data *pdata;

	struct device_node *child;

	int devid, maxleds;

	int i = 0;

	const char *state;
@@ -525,7 +524,7 @@ pca9532_of_populate_pdata(struct device *dev, struct device_node *np) 
	of_property_read_u8_array(np, "nxp,psc", &pdata->psc[PCA9532_PWM_ID_0],

				  ARRAY_SIZE(pdata->psc));



	for_each_available_child_of_node(np, child) {

	for_each_available_child_of_node_scoped(np, child) {

		if (of_property_read_string(child, "label",

					    &pdata->leds[i].name))

			pdata->leds[i].name = child->name;
@@ -538,11 +537,9 @@ pca9532_of_populate_pdata(struct device *dev, struct device_node *np) 
			else if (!strcmp(state, "keep"))

				pdata->leds[i].state = PCA9532_KEEP;

		}

		if (++i >= maxleds) {

			of_node_put(child);

		if (++i >= maxleds)

			break;

	}

	}



	return pdata;

}