Commit af833e7f authored by Benson Leung's avatar Benson Leung Committed by Greg Kroah-Hartman
Browse files

usb: typec: ucsi: psy: Set current max to 100mA for BC 1.2 and Default 



ucsi_psy_get_current_max would return 0mA as the maximum current if
UCSI detected a BC or a Default USB Power sporce.

The comment in this function is true that we can't tell the difference
between DCP/CDP or SDP chargers, but we can guarantee that at least 1-unit
of USB 1.1/2.0 power is available, which is 100mA, which is a better
fallback value than 0, which causes some userspaces, including the ChromeOS
power manager, to regard this as a power source that is not providing
any power.

In reality, 100mA is guaranteed from all sources in these classes.

Signed-off-by: default avatarBenson Leung <bleung@chromium.org>
Reviewed-by: default avatarJameson Thies <jthies@google.com>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
Link: https://lore.kernel.org/r/20250717200805.3710473-1-bleung@chromium.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1e61f6ab

drivers/usb/typec/ucsi/psy.c

+1 −1
Original line number Diff line number Diff line
@@ -164,7 +164,7 @@ static int ucsi_psy_get_current_max(struct ucsi_connector *con, 
	case UCSI_CONSTAT_PWR_OPMODE_DEFAULT:

	/* UCSI can't tell b/w DCP/CDP or USB2/3x1/3x2 SDP chargers */

	default:

		val->intval = 0;

		val->intval = UCSI_TYPEC_DEFAULT_CURRENT * 1000;

		break;

	}

	return 0;

drivers/usb/typec/ucsi/ucsi.h

+4 −3
Original line number Diff line number Diff line
@@ -484,6 +484,7 @@ struct ucsi { 
#define UCSI_MAX_ALTMODES	(UCSI_MAX_SVID * 6)



#define UCSI_TYPEC_VSAFE5V		5000

#define UCSI_TYPEC_DEFAULT_CURRENT	 100

#define UCSI_TYPEC_1_5_CURRENT		1500

#define UCSI_TYPEC_3_0_CURRENT		3000