Commit af9a9730 authored by Zihao Tang's avatar Zihao Tang Committed by Guenter Roeck
Browse files

hwmon: (ina2xx) Convert sysfs sprintf/snprintf family to sysfs_emit 



Fix the following coccicheck warning:

drivers/hwmon/ina2xx.c:313:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/ina2xx.c:453:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/ina2xx.c:484:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/ina2xx.c:540:8-16: WARNING: use scnprintf or sprintf

Signed-off-by: default avatarZihao Tang <tangzihao1@hisilicon.com>
Signed-off-by: default avatarJay Fang <f.fangjian@huawei.com>
Link: https://lore.kernel.org/r/1615892457-35501-1-git-send-email-f.fangjian@huawei.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 9d2227bb

drivers/hwmon/ina2xx.c

+4 −5
Original line number Diff line number Diff line
@@ -310,8 +310,7 @@ static ssize_t ina2xx_value_show(struct device *dev, 
	if (err < 0)

		return err;



	return snprintf(buf, PAGE_SIZE, "%d\n",

			ina2xx_get_value(data, attr->index, regval));

	return sysfs_emit(buf, "%d\n", ina2xx_get_value(data, attr->index, regval));

}



static int ina226_reg_to_alert(struct ina2xx_data *data, u8 bit, u16 regval)
@@ -450,7 +449,7 @@ static ssize_t ina226_alarm_show(struct device *dev, 


	alarm = (regval & BIT(attr->index)) &&

		(regval & INA226_ALERT_FUNCTION_FLAG);

	return snprintf(buf, PAGE_SIZE, "%d\n", alarm);

	return sysfs_emit(buf, "%d\n", alarm);

}



/*
@@ -481,7 +480,7 @@ static ssize_t ina2xx_shunt_show(struct device *dev, 
{

	struct ina2xx_data *data = dev_get_drvdata(dev);



	return snprintf(buf, PAGE_SIZE, "%li\n", data->rshunt);

	return sysfs_emit(buf, "%li\n", data->rshunt);

}



static ssize_t ina2xx_shunt_store(struct device *dev,
@@ -537,7 +536,7 @@ static ssize_t ina226_interval_show(struct device *dev, 
	if (status)

		return status;



	return snprintf(buf, PAGE_SIZE, "%d\n", ina226_reg_to_interval(regval));

	return sysfs_emit(buf, "%d\n", ina226_reg_to_interval(regval));

}



/* shunt voltage */