Commit afc256e1 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Peter Zijlstra
Browse files

locking/spinlocks: Make __raw_* lock ops static 



If CONFIG_GENERIC_LOCKBREAK=y and CONFIG_DEBUG_LOCK_ALLOC=n
(e.g. sh/sdk7786_defconfig):

    kernel/locking/spinlock.c:68:17: warning: no previous prototype for '__raw_spin_lock' [-Wmissing-prototypes]
    kernel/locking/spinlock.c:80:26: warning: no previous prototype for '__raw_spin_lock_irqsave' [-Wmissing-prototypes]
    kernel/locking/spinlock.c:98:17: warning: no previous prototype for '__raw_spin_lock_irq' [-Wmissing-prototypes]
    kernel/locking/spinlock.c:103:17: warning: no previous prototype for '__raw_spin_lock_bh' [-Wmissing-prototypes]
    kernel/locking/spinlock.c:68:17: warning: no previous prototype for '__raw_read_lock' [-Wmissing-prototypes]
    kernel/locking/spinlock.c:80:26: warning: no previous prototype for '__raw_read_lock_irqsave' [-Wmissing-prototypes]
    kernel/locking/spinlock.c:98:17: warning: no previous prototype for '__raw_read_lock_irq' [-Wmissing-prototypes]
    kernel/locking/spinlock.c:103:17: warning: no previous prototype for '__raw_read_lock_bh' [-Wmissing-prototypes]
    kernel/locking/spinlock.c:68:17: warning: no previous prototype for '__raw_write_lock' [-Wmissing-prototypes]
    kernel/locking/spinlock.c:80:26: warning: no previous prototype for '__raw_write_lock_irqsave' [-Wmissing-prototypes]
    kernel/locking/spinlock.c:98:17: warning: no previous prototype for '__raw_write_lock_irq' [-Wmissing-prototypes]
    kernel/locking/spinlock.c:103:17: warning: no previous prototype for '__raw_write_lock_bh' [-Wmissing-prototypes]

All __raw_* lock ops are internal functions without external callers.
Hence fix this by making them static.

Note that if CONFIG_GENERIC_LOCKBREAK=y, no lock ops are inlined, as all
of CONFIG_INLINE_*_LOCK* depend on !GENERIC_LOCKBREAK.

Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: default avatarWaiman Long <longman@redhat.com>
Link: https://lkml.kernel.org/r/7201d7fb408375c6c4df541270d787b1b4a32354.1727879348.git.geert+renesas@glider.be
parent 8cf0b939

kernel/locking/spinlock.c

+4 −4
Original line number Diff line number Diff line
@@ -65,7 +65,7 @@ EXPORT_PER_CPU_SYMBOL(__mmiowb_state); 
 * towards that other CPU that it should break the lock ASAP.

 */

#define BUILD_LOCK_OPS(op, locktype)					\

void __lockfunc __raw_##op##_lock(locktype##_t *lock)			\

static void __lockfunc __raw_##op##_lock(locktype##_t *lock)		\

{									\

	for (;;) {							\

		preempt_disable();					\
@@ -77,7 +77,7 @@ void __lockfunc __raw_##op##_lock(locktype##_t *lock) \ 
	}								\

}									\

									\

unsigned long __lockfunc __raw_##op##_lock_irqsave(locktype##_t *lock)	\

static unsigned long __lockfunc __raw_##op##_lock_irqsave(locktype##_t *lock) \

{									\

	unsigned long flags;						\

									\
@@ -95,12 +95,12 @@ unsigned long __lockfunc __raw_##op##_lock_irqsave(locktype##_t *lock) \ 
	return flags;							\

}									\

									\

void __lockfunc __raw_##op##_lock_irq(locktype##_t *lock)		\

static void __lockfunc __raw_##op##_lock_irq(locktype##_t *lock)	\

{									\

	_raw_##op##_lock_irqsave(lock);					\

}									\

									\

void __lockfunc __raw_##op##_lock_bh(locktype##_t *lock)		\

static void __lockfunc __raw_##op##_lock_bh(locktype##_t *lock)		\

{									\

	unsigned long flags;						\

									\