Commit afc5625e authored by Dan Carpenter's avatar Dan Carpenter Committed by Jakub Kicinski
Browse files

atm: clean up a put_user() calls 



Unlike copy_from_user(), put_user() and get_user() return -EFAULT on
error.  Use the error code directly instead of setting it.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/04a018e8-7433-4f67-8ddd-9357a0114f87@moroto.mountain


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6a21fb7a

net/atm/ioctl.c

+2 −2
Original line number Diff line number Diff line
@@ -68,7 +68,7 @@ static int do_vcc_ioctl(struct socket *sock, unsigned int cmd, 
			goto done;

		}

		error = put_user(sk->sk_sndbuf - sk_wmem_alloc_get(sk),

				 (int __user *)argp) ? -EFAULT : 0;

				 (int __user *)argp);

		goto done;

	case SIOCINQ:

	{
@@ -83,7 +83,7 @@ static int do_vcc_ioctl(struct socket *sock, unsigned int cmd, 
		skb = skb_peek(&sk->sk_receive_queue);

		amount = skb ? skb->len : 0;

		spin_unlock_irq(&sk->sk_receive_queue.lock);

		error = put_user(amount, (int __user *)argp) ? -EFAULT : 0;

		error = put_user(amount, (int __user *)argp);

		goto done;

	}

	case ATM_SETSC: