Commit afdbe492 authored by Thorsten Blum's avatar Thorsten Blum Committed by Daniel Thompson
Browse files

kdb: Remove optional size arguments from strscpy() calls 



If the destination buffer has a fixed length, strscpy() automatically
determines the size of the destination buffer using sizeof() if the
argument is omitted. This makes the explicit sizeof() unnecessary.

Furthermore, CMD_BUFLEN is equal to sizeof(kdb_prompt_str) and can also
be removed. Remove them to shorten and simplify the code.

No functional changes intended.

Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarJustin Stitt <justinstitt@google.com>
Link: https://lore.kernel.org/r/20250319163341.2123-2-thorsten.blum@linux.dev


Signed-off-by: default avatarDaniel Thompson <daniel@riscstar.com>
parent a30d4ff8

kernel/debug/kdb/kdb_io.c

+2 −2
Original line number Diff line number Diff line
@@ -334,7 +334,7 @@ static char *kdb_read(char *buffer, size_t bufsize) 
		*cp = '\0';

		p_tmp = strrchr(buffer, ' ');

		p_tmp = (p_tmp ? p_tmp + 1 : buffer);

		strscpy(tmpbuffer, p_tmp, sizeof(tmpbuffer));

		strscpy(tmpbuffer, p_tmp);

		*cp = tmp;



		len = strlen(tmpbuffer);
@@ -452,7 +452,7 @@ static char *kdb_read(char *buffer, size_t bufsize) 
char *kdb_getstr(char *buffer, size_t bufsize, const char *prompt)

{

	if (prompt && kdb_prompt_str != prompt)

		strscpy(kdb_prompt_str, prompt, CMD_BUFLEN);

		strscpy(kdb_prompt_str, prompt);

	kdb_printf("%s", kdb_prompt_str);

	kdb_nextline = 1;	/* Prompt and input resets line number */

	return kdb_read(buffer, bufsize);