Unverified Commit aff2355d authored by Mark Lord's avatar Mark Lord Committed by Mark Brown
Browse files

spi: pxa2xx: Fix regression when toggling chip select on LPSS devices 



The commit 78b435c9 ("spi: pxa2xx: Introduce __lpss_ssp_update_priv()
helper") broke speaker output on my ASUS UX5304MA laptop. The problem is
in inverted value that got written in the private register.

Simple bug, simple fix.

Fixes: 78b435c9 ("spi: pxa2xx: Introduce __lpss_ssp_update_priv() helper")
Signed-off-by: default avatarMark Lord <mlord@pobox.com>
Tested-by: default avatarMark Lord <mlord@pobox.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20250204174506.149978-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4fd2707e

drivers/spi/spi-pxa2xx.c

+1 −1
Original line number Diff line number Diff line
@@ -399,7 +399,7 @@ static void lpss_ssp_cs_control(struct spi_device *spi, bool enable) 
		lpss_ssp_select_cs(spi, config);



	mask = LPSS_CS_CONTROL_CS_HIGH;

	__lpss_ssp_update_priv(drv_data, config->reg_cs_ctrl, mask, enable ? mask : 0);

	__lpss_ssp_update_priv(drv_data, config->reg_cs_ctrl, mask, enable ? 0 : mask);

	if (config->cs_clk_stays_gated) {

		/*

		 * Changing CS alone when dynamic clock gating is on won't