Commit b042baa5 authored by Yan Zhen's avatar Yan Zhen Committed by Linus Walleij
Browse files

pinctrl: madera: Simplify with dev_err_probe() 



Switch to use dev_err_probe() to simplify the error path and
unify a message template.

Using this helper is totally fine even if err is known to never
be -EPROBE_DEFER.

The benefit compared to a normal dev_err() is the standardized format
of the error code, it being emitted symbolically and the fact that
the error code is returned which allows more compact error paths.

Signed-off-by: default avatarYan Zhen <yanzhen@vivo.com>
Reviewed-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/20240829044835.2047794-1-yanzhen@vivo.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 91bb8d0b

drivers/pinctrl/cirrus/pinctrl-madera-core.c

+3 −6
Original line number Diff line number Diff line
@@ -1063,12 +1063,9 @@ static int madera_pin_probe(struct platform_device *pdev) 
	if (pdata->gpio_configs) {

		ret = pinctrl_register_mappings(pdata->gpio_configs,

						pdata->n_gpio_configs);

		if (ret) {

			dev_err(priv->dev,

				"Failed to register pdata mappings (%d)\n",

				ret);

			return ret;

		}

		if (ret)

			return dev_err_probe(priv->dev, ret,

						"Failed to register pdata mappings\n");

	}



	ret = pinctrl_enable(priv->pctl);