Commit b0445a18 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: Narrow scope of struct pwm_device pointer 



In the expression determining the size of the allocation for chip->pwms
it's more natural to use sizeof(*chip->pwms) than sizeof(*pwm). With
that changed, the variable pwm is only used in a for loop and its scope
can be reduced accordingly.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent 1c9a2ad8

drivers/pwm/core.c

+2 −3
Original line number Diff line number Diff line
@@ -208,7 +208,6 @@ static bool pwm_ops_check(const struct pwm_chip *chip) 
 */

int __pwmchip_add(struct pwm_chip *chip, struct module *owner)

{

	struct pwm_device *pwm;

	unsigned int i;

	int ret;
@@ -220,7 +219,7 @@ int __pwmchip_add(struct pwm_chip *chip, struct module *owner) 


	chip->owner = owner;



	chip->pwms = kcalloc(chip->npwm, sizeof(*pwm), GFP_KERNEL);

	chip->pwms = kcalloc(chip->npwm, sizeof(*chip->pwms), GFP_KERNEL);

	if (!chip->pwms)

		return -ENOMEM;
@@ -236,7 +235,7 @@ int __pwmchip_add(struct pwm_chip *chip, struct module *owner) 
	chip->id = ret;



	for (i = 0; i < chip->npwm; i++) {

		pwm = &chip->pwms[i];

		struct pwm_device *pwm = &chip->pwms[i];



		pwm->chip = chip;

		pwm->hwpwm = i;