Commit b047cbe5 authored by Dmitry Baryshkov's avatar Dmitry Baryshkov Committed by Abhinav Kumar
Browse files

drm/msm/dp: fix msm_dp_utils_pack_sdp_header interface 



The msm_dp_utils_pack_sdp_header() accepts an unlimited-size u32 pointer
for the header output, while it expects a two-element array. It performs
a sizeof check which is always true on 64-bit platforms (since
sizeof(u32*) is 8) and is always false on 32-bit platforms. It returns
an error code which nobody actually checks.

Fix the function interface to accept u32[2] and return void, skipping
all the checks.

Fixes: 55fb8ffc ("drm/msm/dp: add VSC SDP support for YUV420 over DP")
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/626806/
Link: https://lore.kernel.org/r/20241202-fd-dp-audio-fixup-v2-2-d9187ea96dad@linaro.org


[quic_abhinavk@quicinc.com: minor fix in the commit message]
Signed-off-by: default avatarAbhinav Kumar <quic_abhinavk@quicinc.com>
parent 7dee35d7

drivers/gpu/drm/msm/dp/dp_utils.c

+1 −9
Original line number Diff line number Diff line
@@ -74,14 +74,8 @@ u8 msm_dp_utils_calculate_parity(u32 data) 
	return parity_byte;

}



ssize_t msm_dp_utils_pack_sdp_header(struct dp_sdp_header *sdp_header, u32 *header_buff)

void msm_dp_utils_pack_sdp_header(struct dp_sdp_header *sdp_header, u32 header_buff[2])

{

	size_t length;



	length = sizeof(header_buff);

	if (length < DP_SDP_HEADER_SIZE)

		return -ENOSPC;



	header_buff[0] = FIELD_PREP(HEADER_0_MASK, sdp_header->HB0) |

		FIELD_PREP(PARITY_0_MASK, msm_dp_utils_calculate_parity(sdp_header->HB0)) |

		FIELD_PREP(HEADER_1_MASK, sdp_header->HB1) |
@@ -91,6 +85,4 @@ ssize_t msm_dp_utils_pack_sdp_header(struct dp_sdp_header *sdp_header, u32 *head 
		FIELD_PREP(PARITY_2_MASK, msm_dp_utils_calculate_parity(sdp_header->HB2)) |

		FIELD_PREP(HEADER_3_MASK, sdp_header->HB3) |

		FIELD_PREP(PARITY_3_MASK, msm_dp_utils_calculate_parity(sdp_header->HB3));



	return length;

}

drivers/gpu/drm/msm/dp/dp_utils.h

+1 −1
Original line number Diff line number Diff line
@@ -31,6 +31,6 @@ 
u8 msm_dp_utils_get_g0_value(u8 data);

u8 msm_dp_utils_get_g1_value(u8 data);

u8 msm_dp_utils_calculate_parity(u32 data);

ssize_t msm_dp_utils_pack_sdp_header(struct dp_sdp_header *sdp_header, u32 *header_buff);

void msm_dp_utils_pack_sdp_header(struct dp_sdp_header *sdp_header, u32 header_buff[2]);



#endif /* _DP_UTILS_H_ */