Unverified Commit b062a899 authored by Devyn Liu's avatar Devyn Liu Committed by Mark Brown
Browse files

spi: hisi-kunpeng: Fixed the wrong debugfs node name in hisi_spi debugfs initialization 



In hisi_spi_debugfs_init, spi controller pointer is calculated
by container_of macro, and the member is hs->dev. But the host
cannot be calculated offset directly by this. (hs->dev) points
to (pdev->dev), and it is the (host->dev.parent) rather than
(host->dev) points to the (pdev->dev), which is set in
__spi_alloc_controller.

In this patch, this issues is fixed by getting the spi_controller
data from pdev->dev by dev_get_drvdata() directly. (dev->driver_data)
points to the spi controller data in the probe stage.

Signed-off-by: default avatarDevyn Liu <liudingyuan@h-partners.com>
Reviewed-by: default avatarYang Shen <shenyang39@huawei.com>
Link: https://patch.msgid.link/20260108075323.3831574-1-liudingyuan@h-partners.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 383d4f5c

drivers/spi/spi-hisi-kunpeng.c

+1 −3
Original line number Diff line number Diff line
@@ -161,10 +161,8 @@ static const struct debugfs_reg32 hisi_spi_regs[] = { 
static int hisi_spi_debugfs_init(struct hisi_spi *hs)

{

	char name[32];

	struct spi_controller *host = dev_get_drvdata(hs->dev);



	struct spi_controller *host;



	host = container_of(hs->dev, struct spi_controller, dev);

	snprintf(name, 32, "hisi_spi%d", host->bus_num);

	hs->debugfs = debugfs_create_dir(name, NULL);

	if (IS_ERR(hs->debugfs))