Commit b072aa78 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by David S. Miller
Browse files

mlxsw: spectrum_router: Constify struct devlink_dpipe_table_ops 



'struct devlink_dpipe_table_ops' are not modified in this driver.

Constifying these structures moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig:
Before:
======
   text	   data	    bss	    dec	    hex	filename
  15557	    712	      0	  16269	   3f8d	drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
  15789	    488	      0	  16277	   3f95	drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.o

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarWojciech Drewek <wojciech.drewek@intel.com>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 82dc29b9

drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c

+4 −4
Original line number Diff line number Diff line
@@ -283,7 +283,7 @@ static u64 mlxsw_sp_dpipe_table_erif_size_get(void *priv) 
	return MLXSW_CORE_RES_GET(mlxsw_sp->core, MAX_RIFS);

}



static struct devlink_dpipe_table_ops mlxsw_sp_erif_ops = {

static const struct devlink_dpipe_table_ops mlxsw_sp_erif_ops = {

	.matches_dump = mlxsw_sp_dpipe_table_erif_matches_dump,

	.actions_dump = mlxsw_sp_dpipe_table_erif_actions_dump,

	.entries_dump = mlxsw_sp_dpipe_table_erif_entries_dump,
@@ -734,7 +734,7 @@ static u64 mlxsw_sp_dpipe_table_host4_size_get(void *priv) 
	return mlxsw_sp_dpipe_table_host_size_get(mlxsw_sp, AF_INET);

}



static struct devlink_dpipe_table_ops mlxsw_sp_host4_ops = {

static const struct devlink_dpipe_table_ops mlxsw_sp_host4_ops = {

	.matches_dump = mlxsw_sp_dpipe_table_host4_matches_dump,

	.actions_dump = mlxsw_sp_dpipe_table_host_actions_dump,

	.entries_dump = mlxsw_sp_dpipe_table_host4_entries_dump,
@@ -811,7 +811,7 @@ static u64 mlxsw_sp_dpipe_table_host6_size_get(void *priv) 
	return mlxsw_sp_dpipe_table_host_size_get(mlxsw_sp, AF_INET6);

}



static struct devlink_dpipe_table_ops mlxsw_sp_host6_ops = {

static const struct devlink_dpipe_table_ops mlxsw_sp_host6_ops = {

	.matches_dump = mlxsw_sp_dpipe_table_host6_matches_dump,

	.actions_dump = mlxsw_sp_dpipe_table_host_actions_dump,

	.entries_dump = mlxsw_sp_dpipe_table_host6_entries_dump,
@@ -1230,7 +1230,7 @@ mlxsw_sp_dpipe_table_adj_size_get(void *priv) 
	return size;

}



static struct devlink_dpipe_table_ops mlxsw_sp_dpipe_table_adj_ops = {

static const struct devlink_dpipe_table_ops mlxsw_sp_dpipe_table_adj_ops = {

	.matches_dump = mlxsw_sp_dpipe_table_adj_matches_dump,

	.actions_dump = mlxsw_sp_dpipe_table_adj_actions_dump,

	.entries_dump = mlxsw_sp_dpipe_table_adj_entries_dump,