Commit b09ed52d authored by Nicolin Chen's avatar Nicolin Chen Committed by Jason Gunthorpe
Browse files

iommufd/selftest: Fix ioctl return value in _test_cmd_trigger_vevents() 

The ioctl returns 0 upon success, so !0 returning -1 breaks the selftest.

Drop the '!' to fix it.

Fixes: 1d235d84 ("iommu/selftest: prevent use of uninitialized variable")
Link: https://patch.msgid.link/r/20251014214847.1113759-1-nicolinc@nvidia.com


Signed-off-by: default avatarNicolin Chen <nicolinc@nvidia.com>
Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent cb30dfa7

tools/testing/selftests/iommu/iommufd_utils.h

+2 −2
Original line number Diff line number Diff line
@@ -1044,7 +1044,7 @@ static int _test_cmd_trigger_vevents(int fd, __u32 dev_id, __u32 nvevents) 
	};



	while (nvevents--) {

		if (!ioctl(fd, _IOMMU_TEST_CMD(IOMMU_TEST_OP_TRIGGER_VEVENT),

		if (ioctl(fd, _IOMMU_TEST_CMD(IOMMU_TEST_OP_TRIGGER_VEVENT),

			  &trigger_vevent_cmd))

			return -1;

	}