Commit b0ba7345 authored by Shahar Shitrit's avatar Shahar Shitrit Committed by Paolo Abeni
Browse files

net/mlx5e: Refine TX timeout handling to skip non-timed-out SQ 



mlx5e_tx_timeout_work() is invoked when the dev_watchdog reports a
timed-out TX queue. Currently, the recovery flow is triggered for all
stopped SQs, which is not always correct — some SQs may be temporarily
stopped without actually timing out. Attempting to recover such SQs
results in no EQE being polled (since no real timeout occurred), which
the driver misinterprets as a recovery failure, unnecessarily causing
channel reopening.

Improve the logic to initiate recovery only for SQs that are both
stopped and timed out. Utilize the helper introduced in the previous
patch to determine whether the netdevice watchdog timeout period has
elapsed since the SQ’s last transmit timestamp.

Signed-off-by: default avatarShahar Shitrit <shshitrit@nvidia.com>
Reviewed-by: default avatarYael Chemla <ychemla@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/1768209383-1546791-4-git-send-email-tariqt@nvidia.com


Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 3ae02d65

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+1 −1
Original line number Diff line number Diff line
@@ -5137,7 +5137,7 @@ static void mlx5e_tx_timeout_work(struct work_struct *work) 
			netdev_get_tx_queue(netdev, i);

		struct mlx5e_txqsq *sq = priv->txq2sq[i];



		if (!netif_xmit_stopped(dev_queue))

		if (!netif_xmit_timeout_ms(dev_queue))

			continue;



		if (mlx5e_reporter_tx_timeout(sq))