Commit b0c8a640 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: open code io_account_cq_overflow() 



io_account_cq_overflow() doesn't help explaining what's going on in
there, and it'll become even smaller with following patches, so open
code it.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/e4333fa0d371f519e52a71148ebdffed4b8d3aa9.1746788718.git.asml.silence@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 19a94da4

io_uring/io_uring.c

+4 −9
Original line number Diff line number Diff line
@@ -381,14 +381,6 @@ static __cold struct io_ring_ctx *io_ring_ctx_alloc(struct io_uring_params *p) 
	return NULL;

}



static void io_account_cq_overflow(struct io_ring_ctx *ctx)

{

	struct io_rings *r = ctx->rings;



	WRITE_ONCE(r->cq_overflow, READ_ONCE(r->cq_overflow) + 1);

	ctx->cq_extra--;

}



static void io_clean_op(struct io_kiocb *req)

{

	if (unlikely(req->flags & REQ_F_BUFFER_SELECTED))
@@ -742,12 +734,15 @@ static bool io_cqring_event_overflow(struct io_ring_ctx *ctx, u64 user_data, 
	ocqe = kmalloc(ocq_size, GFP_ATOMIC | __GFP_ACCOUNT);

	trace_io_uring_cqe_overflow(ctx, user_data, res, cflags, ocqe);

	if (!ocqe) {

		struct io_rings *r = ctx->rings;



		/*

		 * If we're in ring overflow flush mode, or in task cancel mode,

		 * or cannot allocate an overflow entry, then we need to drop it

		 * on the floor.

		 */

		io_account_cq_overflow(ctx);

		WRITE_ONCE(r->cq_overflow, READ_ONCE(r->cq_overflow) + 1);

		ctx->cq_extra--;

		set_bit(IO_CHECK_CQ_DROPPED_BIT, &ctx->check_cq);

		return false;

	}