Commit b0c959fe authored by Pavel Zhigulin's avatar Pavel Zhigulin Committed by Jakub Kicinski
Browse files

net: mlxsw: linecards: fix missing error check in mlxsw_linecard_devlink_info_get() 



The call to devlink_info_version_fixed_put() in
mlxsw_linecard_devlink_info_get() did not check for errors,
although it is checked everywhere in the code.

Add missed 'err' check to the mlxsw_linecard_devlink_info_get()

Fixes: 3fc0c519 ("mlxsw: core_linecards: Expose device PSID over device info")
Signed-off-by: default avatarPavel Zhigulin <Pavel.Zhigulin@kaspersky.com>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Link: https://patch.msgid.link/20251113161922.813828-1-Pavel.Zhigulin@kaspersky.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e6751b0b

drivers/net/ethernet/mellanox/mlxsw/core_linecards.c

+2 −0
Original line number Diff line number Diff line
@@ -601,6 +601,8 @@ int mlxsw_linecard_devlink_info_get(struct mlxsw_linecard *linecard, 
		err = devlink_info_version_fixed_put(req,

						     DEVLINK_INFO_VERSION_GENERIC_FW_PSID,

						     info->psid);

		if (err)

			goto unlock;



		sprintf(buf, "%u.%u.%u", info->fw_major, info->fw_minor,

			info->fw_sub_minor);