Commit b0c9d8ae authored by Sanman Pradhan's avatar Sanman Pradhan Committed by Guenter Roeck
Browse files

hwmon: (peci/cputemp) Fix off-by-one in cputemp_is_visible() 



cputemp_is_visible() validates the channel index against
CPUTEMP_CHANNEL_NUMS, but currently uses '>' instead of '>='.
As a result, channel == CPUTEMP_CHANNEL_NUMS is not rejected even though
valid indices are 0 .. CPUTEMP_CHANNEL_NUMS - 1.

Fix the bounds check by using '>=' so invalid channel indices are
rejected before indexing the core bitmap.

Fixes: bf3608f3 ("hwmon: peci: Add cputemp driver")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarSanman Pradhan <psanman@juniper.net>
Link: https://lore.kernel.org/r/20260323002352.93417-3-sanman.pradhan@hpe.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 0adc752b

drivers/hwmon/peci/cputemp.c

+1 −1
Original line number Diff line number Diff line
@@ -319,7 +319,7 @@ static umode_t cputemp_is_visible(const void *data, enum hwmon_sensor_types type 
{

	const struct peci_cputemp *priv = data;



	if (channel > CPUTEMP_CHANNEL_NUMS)

	if (channel >= CPUTEMP_CHANNEL_NUMS)

		return 0;



	if (channel < channel_core)