Commit b0d14fc4 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Linus Torvalds
Browse files

mm/kmemleak.c: use address-of operator on section symbols 



Clang warns:

  mm/kmemleak.c:1955:28: warning: array comparison always evaluates to a constant [-Wtautological-compare]
        if (__start_ro_after_init < _sdata || __end_ro_after_init > _edata)
                                  ^
  mm/kmemleak.c:1955:60: warning: array comparison always evaluates to a constant [-Wtautological-compare]
        if (__start_ro_after_init < _sdata || __end_ro_after_init > _edata)

These are not true arrays, they are linker defined symbols, which are just
addresses.  Using the address of operator silences the warning and does
not change the resulting assembly with either clang/ld.lld or gcc/ld
(tested with diff + objdump -Dr).

Suggested-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Acked-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/895
Link: http://lkml.kernel.org/r/20200220051551.44000-1-natechancellor@gmail.com


Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 667c7901

mm/kmemleak.c

+1 −1
Original line number Diff line number Diff line
@@ -1947,7 +1947,7 @@ void __init kmemleak_init(void) 
	create_object((unsigned long)__bss_start, __bss_stop - __bss_start,

		      KMEMLEAK_GREY, GFP_ATOMIC);

	/* only register .data..ro_after_init if not within .data */

	if (__start_ro_after_init < _sdata || __end_ro_after_init > _edata)

	if (&__start_ro_after_init < &_sdata || &__end_ro_after_init > &_edata)

		create_object((unsigned long)__start_ro_after_init,

			      __end_ro_after_init - __start_ro_after_init,

			      KMEMLEAK_GREY, GFP_ATOMIC);