Commit b0dbd5db authored by Yang Wang's avatar Yang Wang Committed by Alex Deucher
Browse files

drm/amd/pm: force send pcie parmater on navi1x

v1:
the PMFW didn't initialize the PCIe DPM parameters
and requires the KMD to actively provide these parameters.

v2:
clean & remove unused code logic (lijo)

Fixes: 1a18607c ("drm/amd/pm: override pcie dpm parameters only if it is necessary")
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4671


Signed-off-by: default avatarYang Wang <kevinyang.wang@amd.com>
Reviewed-by: default avatarLijo Lazar <lijo.lazar@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent b4ba5c95
Loading
Loading
Loading
Loading
+15 −18
Original line number Diff line number Diff line
@@ -2207,8 +2207,6 @@ static int navi10_update_pcie_parameters(struct smu_context *smu,
	dpm_context->dpm_tables.pcie_table.lclk_levels = NUM_LINK_LEVELS;

	for (i = 0; i < NUM_LINK_LEVELS; i++) {
		if (pptable->PcieGenSpeed[i] > pcie_gen_cap ||
			pptable->PcieLaneCount[i] > pcie_width_cap) {
		dpm_context->dpm_tables.pcie_table.pcie_gen[i] =
			pptable->PcieGenSpeed[i] > pcie_gen_cap ?
			pcie_gen_cap : pptable->PcieGenSpeed[i];
@@ -2223,8 +2221,7 @@ static int navi10_update_pcie_parameters(struct smu_context *smu,
						      smu_pcie_arg,
						      NULL);
		if (ret)
				break;
		}
			return ret;
	}

	return ret;