Commit b107c63d authored by Ashutosh Dixit's avatar Ashutosh Dixit
Browse files

drm/xe/oa: Fix "Missing outer runtime PM protection" warning 



Fix the following drm_WARN:

[953.586396] xe 0000:00:02.0: [drm] Missing outer runtime PM protection
...
<4> [953.587090]  ? xe_pm_runtime_get_noresume+0x8d/0xa0 [xe]
<4> [953.587208]  guc_exec_queue_add_msg+0x28/0x130 [xe]
<4> [953.587319]  guc_exec_queue_fini+0x3a/0x40 [xe]
<4> [953.587425]  xe_exec_queue_destroy+0xb3/0xf0 [xe]
<4> [953.587515]  xe_oa_release+0x9c/0xc0 [xe]

Suggested-by: default avatarJohn Harrison <john.c.harrison@intel.com>
Suggested-by: default avatarMatthew Brost <matthew.brost@intel.com>
Fixes: e936f885 ("drm/xe/oa/uapi: Expose OA stream fd")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarAshutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241109032003.3093811-1-ashutosh.dixit@intel.com
parent db696095

drivers/gpu/drm/xe/xe_oa.c

+2 −0
Original line number Diff line number Diff line
@@ -1614,9 +1614,11 @@ static int xe_oa_release(struct inode *inode, struct file *file) 
	struct xe_oa_stream *stream = file->private_data;

	struct xe_gt *gt = stream->gt;



	xe_pm_runtime_get(gt_to_xe(gt));

	mutex_lock(&gt->oa.gt_lock);

	xe_oa_destroy_locked(stream);

	mutex_unlock(&gt->oa.gt_lock);

	xe_pm_runtime_put(gt_to_xe(gt));



	/* Release the reference the OA stream kept on the driver */

	drm_dev_put(&gt_to_xe(gt)->drm);