Commit b117befe authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

Merge branch 'net-mlx5e-reduce-interface-downtime-on-configuration-change' 

Tariq Toukan says:

====================
net/mlx5e: Reduce interface downtime on configuration change

This series significantly reduces the interface downtime while swapping
channels during a configuration change, on capable devices.

Here we remove an old requirement on operations ordering that became
obsolete on recent capable devices. This helps cutting the downtime by a
factor of magnitude, ~80% in our example.

Perf numbers:
Measured the number of dropped packets in a simple ping flood test,
during a configuration change operation, that switches the number of
channels from 247 to 248.

Before: 71 packets lost
After:  15 packets lost, ~80% saving.
====================

Link: https://patch.msgid.link/1761831159-1013140-1-git-send-email-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parents 52665fcc 3b88a535

drivers/net/ethernet/mellanox/mlx5/core/en.h

+3 −1
Original line number Diff line number Diff line
@@ -1156,7 +1156,9 @@ extern const struct ethtool_ops mlx5e_ethtool_ops; 
int mlx5e_create_mkey(struct mlx5_core_dev *mdev, u32 pdn, u32 *mkey);

int mlx5e_create_mdev_resources(struct mlx5_core_dev *mdev, bool create_tises);

void mlx5e_destroy_mdev_resources(struct mlx5_core_dev *mdev);

int mlx5e_refresh_tirs(struct mlx5e_priv *priv, bool enable_uc_lb,

int mlx5e_modify_tirs_lb(struct mlx5_core_dev *mdev, bool enable_uc_lb,

			 bool enable_mc_lb);

int mlx5e_refresh_tirs(struct mlx5_core_dev *mdev, bool enable_uc_lb,

		       bool enable_mc_lb);

void mlx5e_mkey_set_relaxed_ordering(struct mlx5_core_dev *mdev, void *mkc);

drivers/net/ethernet/mellanox/mlx5/core/en/rss.c

+2 −0
Original line number Diff line number Diff line
@@ -231,6 +231,8 @@ mlx5e_rss_create_tir(struct mlx5e_rss *rss, enum mlx5_traffic_types tt, 
				    rqtn, rss_inner);

	mlx5e_tir_builder_build_packet_merge(builder, pkt_merge_param);

	rss_tt = mlx5e_rss_get_tt_config(rss, tt);

	mlx5e_tir_builder_build_self_lb_block(builder, rss->params.self_lb_blk,

					      rss->params.self_lb_blk);

	mlx5e_tir_builder_build_rss(builder, &rss->hash, &rss_tt, inner);



	err = mlx5e_tir_init(tir, builder, rss->mdev, true);

drivers/net/ethernet/mellanox/mlx5/core/en/rss.h

+1 −0
Original line number Diff line number Diff line
@@ -23,6 +23,7 @@ struct mlx5e_rss_init_params { 
struct mlx5e_rss_params {

	bool inner_ft_support;

	u32 drop_rqn;

	bool self_lb_blk;

};



struct mlx5e_rss_params_traffic_type

drivers/net/ethernet/mellanox/mlx5/core/en/rx_res.c

+7 −0
Original line number Diff line number Diff line
@@ -71,6 +71,8 @@ static int mlx5e_rx_res_rss_init_def(struct mlx5e_rx_res *res, 
	rss_params = (struct mlx5e_rss_params) {

		.inner_ft_support = inner_ft_support,

		.drop_rqn = res->drop_rqn,

		.self_lb_blk =

			res->features & MLX5E_RX_RES_FEATURE_SELF_LB_BLOCK,

	};



	rss = mlx5e_rss_init(res->mdev, &rss_params, &init_params);
@@ -104,6 +106,8 @@ int mlx5e_rx_res_rss_init(struct mlx5e_rx_res *res, u32 rss_idx, unsigned int in 
	rss_params = (struct mlx5e_rss_params) {

		.inner_ft_support = inner_ft_support,

		.drop_rqn = res->drop_rqn,

		.self_lb_blk =

			res->features & MLX5E_RX_RES_FEATURE_SELF_LB_BLOCK,

	};



	rss = mlx5e_rss_init(res->mdev, &rss_params, &init_params);
@@ -346,6 +350,7 @@ static struct mlx5e_rx_res *mlx5e_rx_res_alloc(struct mlx5_core_dev *mdev, unsig 
static int mlx5e_rx_res_channels_init(struct mlx5e_rx_res *res)

{

	bool inner_ft_support = res->features & MLX5E_RX_RES_FEATURE_INNER_FT;

	bool self_lb_blk = res->features & MLX5E_RX_RES_FEATURE_SELF_LB_BLOCK;

	struct mlx5e_tir_builder *builder;

	int err = 0;

	int ix;
@@ -376,6 +381,8 @@ static int mlx5e_rx_res_channels_init(struct mlx5e_rx_res *res) 
					    mlx5e_rqt_get_rqtn(&res->channels[ix].direct_rqt),

					    inner_ft_support);

		mlx5e_tir_builder_build_packet_merge(builder, &res->pkt_merge_param);

		mlx5e_tir_builder_build_self_lb_block(builder, self_lb_blk,

						      self_lb_blk);

		mlx5e_tir_builder_build_direct(builder);



		err = mlx5e_tir_init(&res->channels[ix].direct_tir, builder, res->mdev, true);

drivers/net/ethernet/mellanox/mlx5/core/en/rx_res.h

+1 −0
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ enum mlx5e_rx_res_features { 
	MLX5E_RX_RES_FEATURE_INNER_FT = BIT(0),

	MLX5E_RX_RES_FEATURE_PTP = BIT(1),

	MLX5E_RX_RES_FEATURE_MULTI_VHCA = BIT(2),

	MLX5E_RX_RES_FEATURE_SELF_LB_BLOCK = BIT(3),

};



/* Setup */