Commit b1195035 authored by Herbert Xu's avatar Herbert Xu
Browse files

KEYS: asymmetric: Fix sign/verify on pkcs1pad without a hash 



The new sign/verify code broke the case of pkcs1pad without a
hash algorithm.  Fix it by setting issig correctly for this case.

Fixes: 63ba4d67 ("KEYS: asymmetric: Use new crypto interface without scatterlists")
Cc: stable@vger.kernel.org # v6.5
Reported-by: default avatarDenis Kenzior <denkenz@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Tested-by: default avatarDenis Kenzior <denkenz@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 152d0bcd

crypto/asymmetric_keys/public_key.c

+2 −3
Original line number Diff line number Diff line
@@ -81,14 +81,13 @@ software_key_determine_akcipher(const struct public_key *pkey, 
		 * RSA signatures usually use EMSA-PKCS1-1_5 [RFC3447 sec 8.2].

		 */

		if (strcmp(encoding, "pkcs1") == 0) {

			*sig = op == kernel_pkey_sign ||

			       op == kernel_pkey_verify;

			if (!hash_algo) {

				*sig = false;

				n = snprintf(alg_name, CRYPTO_MAX_ALG_NAME,

					     "pkcs1pad(%s)",

					     pkey->pkey_algo);

			} else {

				*sig = op == kernel_pkey_sign ||

				       op == kernel_pkey_verify;

				n = snprintf(alg_name, CRYPTO_MAX_ALG_NAME,

					     "pkcs1pad(%s,%s)",

					     pkey->pkey_algo, hash_algo);