Commit b12daf36 authored by Dominique Martinet's avatar Dominique Martinet Committed by Greg Kroah-Hartman
Browse files

USB: lower "Device is not authorized for usage" message to info 



This message is not a useful error in practice:
- when using tools such as usbguard, the message is always printed but
  it does not presume anything regarding the actual device acceptance
  (later 'authorized to connect' message is at info level, and not
   displayed on console)
- this can be a source of flood if a usb device connection is flaky
- ... and it is only displayed as the result of an admin action
  (modifying authorized_default), working as intended, so not likely
  to be an error.

This is still useful to know when looking at usb devices problems, so
info seems appropriate for this class of messages together with the
later eventual authorized message.

Signed-off-by: default avatarDominique Martinet <dominique.martinet@atmark-techno.com>
Link: https://lore.kernel.org/r/20250801-usb-auth-v1-1-a59bfdf0293f@atmark-techno.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 01570974

drivers/usb/core/driver.c

+2 −2
Original line number Diff line number Diff line
@@ -332,10 +332,10 @@ static int usb_probe_interface(struct device *dev) 
		return error;



	if (udev->authorized == 0) {

		dev_err(&intf->dev, "Device is not authorized for usage\n");

		dev_info(&intf->dev, "Device is not authorized for usage\n");

		return error;

	} else if (intf->authorized == 0) {

		dev_err(&intf->dev, "Interface %d is not authorized for usage\n",

		dev_info(&intf->dev, "Interface %d is not authorized for usage\n",

				intf->altsetting->desc.bInterfaceNumber);

		return error;

	}

drivers/usb/core/generic.c

+1 −1
Original line number Diff line number Diff line
@@ -243,7 +243,7 @@ int usb_generic_driver_probe(struct usb_device *udev) 
	 * with the driver core and lets interface drivers bind to them.

	 */

	if (udev->authorized == 0)

		dev_err(&udev->dev, "Device is not authorized for usage\n");

		dev_info(&udev->dev, "Device is not authorized for usage\n");

	else {

		c = usb_choose_configuration(udev);

		if (c >= 0) {