Commit b134a580 authored by Matthieu Baerts's avatar Matthieu Baerts Committed by Jakub Kicinski
Browse files

selftests: mptcp: join: correctly check for no RST 



The commit mentioned below was more tolerant with the number of RST seen
during a test because in some uncontrollable situations, multiple RST
can be generated.

But it was not taking into account the case where no RST are expected:
this validation was then no longer reporting issues for the 0 RST case
because it is not possible to have less than 0 RST in the counter. This
patch fixes the issue by adding a specific condition.

Fixes: 6bf41020 ("selftests: mptcp: update and extend fastclose test-cases")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarMat Martineau <martineau@kernel.org>
Signed-off-by: default avatarMatthieu Baerts <matttbe@kernel.org>
Signed-off-by: default avatarMat Martineau <martineau@kernel.org>
Link: https://lore.kernel.org/r/20231018-send-net-20231018-v1-1-17ecb002e41d@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 389db4fd

tools/testing/selftests/net/mptcp/mptcp_join.sh

+6 −2
Original line number Diff line number Diff line
@@ -1432,7 +1432,9 @@ chk_rst_nr() 
	count=$(get_counter ${ns_tx} "MPTcpExtMPRstTx")

	if [ -z "$count" ]; then

		print_skip

	elif [ $count -lt $rst_tx ]; then

	# accept more rst than expected except if we don't expect any

	elif { [ $rst_tx -ne 0 ] && [ $count -lt $rst_tx ]; } ||

	     { [ $rst_tx -eq 0 ] && [ $count -ne 0 ]; }; then

		fail_test "got $count MP_RST[s] TX expected $rst_tx"

	else

		print_ok
@@ -1442,7 +1444,9 @@ chk_rst_nr() 
	count=$(get_counter ${ns_rx} "MPTcpExtMPRstRx")

	if [ -z "$count" ]; then

		print_skip

	elif [ "$count" -lt "$rst_rx" ]; then

	# accept more rst than expected except if we don't expect any

	elif { [ $rst_rx -ne 0 ] && [ $count -lt $rst_rx ]; } ||

	     { [ $rst_rx -eq 0 ] && [ $count -ne 0 ]; }; then

		fail_test "got $count MP_RST[s] RX expected $rst_rx"

	else

		print_ok