Commit b14e40f5 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Philipp Zabel
Browse files

reset: k210: fix OF node leak in probe() error path 



Driver is leaking OF node reference on memory allocation failure.
Acquire the OF node reference after memory allocation to fix this and
keep it simple.

Fixes: 5a2308da ("riscv: Add Canaan Kendryte K210 reset controller")
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20240825-reset-cleanup-scoped-v1-2-03f6d834f8c0@linaro.org


Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
parent 5f58a88c

drivers/reset/reset-k210.c

+2 −1
Original line number Diff line number Diff line
@@ -90,7 +90,7 @@ static const struct reset_control_ops k210_rst_ops = { 
static int k210_rst_probe(struct platform_device *pdev)

{

	struct device *dev = &pdev->dev;

	struct device_node *parent_np = of_get_parent(dev->of_node);

	struct device_node *parent_np;

	struct k210_rst *ksr;



	dev_info(dev, "K210 reset controller\n");
@@ -99,6 +99,7 @@ static int k210_rst_probe(struct platform_device *pdev) 
	if (!ksr)

		return -ENOMEM;



	parent_np = of_get_parent(dev->of_node);

	ksr->map = syscon_node_to_regmap(parent_np);

	of_node_put(parent_np);

	if (IS_ERR(ksr->map))