Commit b1754a69 authored Jan 20, 2025 by Russell King (Oracle) Committed by Jakub Kicinski Jan 20, 2025

net: phylink: fix regression when binding a PHY



Some PHYs don't support clause 45 access, and return -EOPNOTSUPP from
phy_modify_mmd(), which causes phylink_bringup_phy() to fail. Prevent
this failure by allowing -EOPNOTSUPP to also mean success.

Reported-by: Jiawen Wu <jiawenwu@trustnetic.com>
Tested-by: Jiawen Wu <jiawenwu@trustnetic.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/E1tZp1a-001V62-DT@rmk-PC.armlinux.org.uk


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent d73a4602

drivers/net/phy/phylink.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -2268,7 +2268,11 @@ static int phylink_bringup_phy(struct phylink pl, struct phy_device phy,
		/* Explicitly configure whether the PHY is allowed to stop it's
		* receive clock.
		*/
		return phy_eee_rx_clock_stop(phy, pl->config->eee_rx_clk_stop_enable);
		ret = phy_eee_rx_clock_stop(phy, pl->config->eee_rx_clk_stop_enable);
		if (ret == -EOPNOTSUPP)
		ret = 0;

		return ret;
		}

		static int phylink_attach_phy(struct phylink pl, struct phy_device phy,