Commit b178ad64 authored by Jai Luthra's avatar Jai Luthra Committed by Greg Kroah-Hartman
Browse files

staging: vc04_services: Cleanup VCHIQ TODO entries 

Raspberry Pi downstream drivers using VCHIQ have changed a lot since
kernel version 4.4 mentioned in the TODO, and are tangential to the
destaing process - so drop those items from the list.

Secondly, the code indentation for the vchiq interface driver is not so
bad anymore since Umang's series (linked below) got merged, so drop it
from the TODO.

Link: https://lore.kernel.org/all/20241013112128.397249-1-umang.jain@ideasonboard.com/


Acked-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarJai Luthra <jai.luthra@ideasonboard.com>
Reviewed-by: default avatarStefan Wahren <wahrenst@gmx.net>
Link: https://patch.msgid.link/20251029-vchiq-destage-v3-5-da8d6c83c2c5@ideasonboard.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bf9f0b00

drivers/staging/vc04_services/interface/TODO

+0 −24
Original line number Diff line number Diff line 
* Import drivers using VCHI.



VCHI is just a tool to let drivers talk to the firmware.  Here are

some of the ones we want:



  - vc_mem (https://github.com/raspberrypi/linux/blob/rpi-4.4.y/drivers/char/broadcom/vc_mem.c)



  This driver is what the vcdbg userspace program uses to set up its

  requests to the firmware, which are transmitted across VCHIQ.  vcdbg

  is really useful for debugging firmware interactions.



  - VCSM (https://github.com/raspberrypi/linux/tree/rpi-4.4.y/drivers/char/broadcom/vc_sm)



  This driver is used for talking about regions of VC memory across

  firmware protocols including VCHI.  We'll want to extend this driver

  to manage these buffers as dmabufs so that we can zero-copy import

  camera images into vc4 for rendering/display.



* Documentation



A short top-down description of this driver's architecture (function of

kthreads, userspace, limitations) could be very helpful for reviewers.
 


* Reformat core code with more sane indentations



The code follows the 80 characters limitation yet tends to go 3 or 4 levels of

indentation deep making it very unpleasant to read. This is specially relevant

in the character driver ioctl code and in the core thread functions.