Commit b1a80f4b authored by Ilya Leoshkevich's avatar Ilya Leoshkevich Committed by Andrew Morton
Browse files

kmsan: do not pass NULL pointers as 0 

sparse complains about passing NULL pointers as 0.  Fix all instances.

Link: https://lkml.kernel.org/r/20240627145754.27333-3-iii@linux.ibm.com


Signed-off-by: default avatarIlya Leoshkevich <iii@linux.ibm.com>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202406272033.KejtfLkw-lkp@intel.com/


Reviewed-by: default avatarAlexander Potapenko <glider@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Marco Elver <elver@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent b072880d

mm/kmsan/hooks.c

+8 −7
Original line number Diff line number Diff line
@@ -303,7 +303,8 @@ void kmsan_handle_urb(const struct urb *urb, bool is_out) 
	if (is_out)

		kmsan_internal_check_memory(urb->transfer_buffer,

					    urb->transfer_buffer_length,

					    /*user_addr*/ 0, REASON_SUBMIT_URB);

					    /*user_addr*/ NULL,

					    REASON_SUBMIT_URB);

	else

		kmsan_internal_unpoison_memory(urb->transfer_buffer,

					       urb->transfer_buffer_length,
@@ -316,14 +317,14 @@ static void kmsan_handle_dma_page(const void *addr, size_t size, 
{

	switch (dir) {

	case DMA_BIDIRECTIONAL:

		kmsan_internal_check_memory((void *)addr, size, /*user_addr*/ 0,

					    REASON_ANY);

		kmsan_internal_check_memory((void *)addr, size,

					    /*user_addr*/ NULL, REASON_ANY);

		kmsan_internal_unpoison_memory((void *)addr, size,

					       /*checked*/ false);

		break;

	case DMA_TO_DEVICE:

		kmsan_internal_check_memory((void *)addr, size, /*user_addr*/ 0,

					    REASON_ANY);

		kmsan_internal_check_memory((void *)addr, size,

					    /*user_addr*/ NULL, REASON_ANY);

		break;

	case DMA_FROM_DEVICE:

		kmsan_internal_unpoison_memory((void *)addr, size,
@@ -418,8 +419,8 @@ void kmsan_check_memory(const void *addr, size_t size) 
{

	if (!kmsan_enabled)

		return;

	return kmsan_internal_check_memory((void *)addr, size, /*user_addr*/ 0,

					   REASON_ANY);

	return kmsan_internal_check_memory((void *)addr, size,

					   /*user_addr*/ NULL, REASON_ANY);

}

EXPORT_SYMBOL(kmsan_check_memory);

mm/kmsan/instrumentation.c

+2 −2
Original line number Diff line number Diff line
@@ -315,8 +315,8 @@ void __msan_warning(u32 origin) 
	if (!kmsan_enabled || kmsan_in_runtime())

		return;

	kmsan_enter_runtime();

	kmsan_report(origin, /*address*/ 0, /*size*/ 0,

		     /*off_first*/ 0, /*off_last*/ 0, /*user_addr*/ 0,

	kmsan_report(origin, /*address*/ NULL, /*size*/ 0,

		     /*off_first*/ 0, /*off_last*/ 0, /*user_addr*/ NULL,

		     REASON_ANY);

	kmsan_leave_runtime();

}