Commit b1aabb8e authored by Ma Ke's avatar Ma Ke Committed by Greg Kroah-Hartman
Browse files

staging: gpib: Fix device reference leak in fmh_gpib driver 



The fmh_gpib driver contains a device reference count leak in
fmh_gpib_attach_impl() where driver_find_device() increases the
reference count of the device by get_device() when matching but this
reference is not properly decreased. Add put_device() in
fmh_gpib_detach(), which ensures that the reference count of the
device is correctly managed.

Found by code review.

Cc: stable <stable@kernel.org>
Fixes: 8e4841a0 ("staging: gpib: Add Frank Mori Hess FPGA PCI GPIB driver")
Signed-off-by: default avatarMa Ke <make24@iscas.ac.cn>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent aaf2af1e

drivers/staging/gpib/fmh_gpib/fmh_gpib.c

+5 −0
Original line number Diff line number Diff line
@@ -1517,6 +1517,11 @@ void fmh_gpib_detach(struct gpib_board *board) 
					   resource_size(e_priv->gpib_iomem_res));

	}

	fmh_gpib_generic_detach(board);



	if (board->dev) {

		put_device(board->dev);

		board->dev = NULL;

	}

}



static int fmh_gpib_pci_attach_impl(struct gpib_board *board,