Commit b1c7cd6c authored by Erick Archer's avatar Erick Archer Committed by Luiz Augusto von Dentz
Browse files

tty: rfcomm: prefer array indexing over pointer arithmetic 



Refactor the list_for_each_entry() loop of rfcomm_get_dev_list()
function to use array indexing instead of pointer arithmetic.

This way, the code is more readable and idiomatic.

Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarErick Archer <erick.archer@outlook.com>
Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
parent 7d2c7ddb

net/bluetooth/rfcomm/tty.c

+6 −6
Original line number Diff line number Diff line
@@ -527,12 +527,12 @@ static int rfcomm_get_dev_list(void __user *arg) 
	list_for_each_entry(dev, &rfcomm_dev_list, list) {

		if (!tty_port_get(&dev->port))

			continue;

		(di + n)->id      = dev->id;

		(di + n)->flags   = dev->flags;

		(di + n)->state   = dev->dlc->state;

		(di + n)->channel = dev->channel;

		bacpy(&(di + n)->src, &dev->src);

		bacpy(&(di + n)->dst, &dev->dst);

		di[n].id      = dev->id;

		di[n].flags   = dev->flags;

		di[n].state   = dev->dlc->state;

		di[n].channel = dev->channel;

		bacpy(&di[n].src, &dev->src);

		bacpy(&di[n].dst, &dev->dst);

		tty_port_put(&dev->port);

		if (++n >= dev_num)

			break;